Skip to content

[service-utils] Omit team_id for client usageV2 events #6213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2025
Merged

[service-utils] Omit team_id for client usageV2 events #6213

merged 1 commit into from
Feb 9, 2025

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Feb 9, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on modifying the UsageV2Event interface to create a new ClientUsageV2Event interface that omits the team_id property for client usage events. It also updates the sendUsageV2Events function to accommodate this change.

Detailed summary

  • Renamed UsageV2Event to ClientUsageV2Event and removed team_id.
  • Added team_id back to UsageV2Event as an extension of ClientUsageV2Event.
  • Updated sendUsageV2Events function to conditionally accept either UsageV2Event[] or ClientUsageV2Event[] based on serviceKey.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner February 9, 2025 09:59
@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2025

🦋 Changeset detected

Latest commit: 3b49326

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 9:59am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 9:59am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 9:59am
thirdweb-www 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 9:59am
wallet-ui 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 9:59am

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@arcoraven arcoraven merged commit cad9c74 into main Feb 9, 2025
28 of 31 checks passed
@arcoraven arcoraven deleted the ph/omitTeamId branch February 9, 2025 09:59
@codecov
Copy link

codecov bot commented Feb 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (6f2f92d) to head (3b49326).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6213   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files        1161     1161           
  Lines       64289    64289           
  Branches     5196     5196           
=======================================
  Hits        36468    36468           
  Misses      27095    27095           
  Partials      726      726
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 6f2f92d
packages 54.89% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@joaquim-verges joaquim-verges mentioned this pull request Feb 9, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.28 KB (0%) 926 ms (0%) 3.1 s (-6.83% 🔽) 4 s
thirdweb (cjs) 122.06 KB (0%) 2.5 s (0%) 6 s (-10.14% 🔽) 8.5 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 427 ms (+116.37% 🔺) 539 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 179 ms (+222.23% 🔺) 189 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 634 ms (-36.71% 🔽) 1.1 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arcoraven arcoraven

Labels

packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arcoraven